Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: touchable ripple overlay #3875

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

lukewalczak
Copy link
Member

Summary

Correct the TouchableRipple underlay color support, when the ripple is not supported, so the additional layer is displayed, to have a similar effect to TouchableHighlight.

Related issue

Test plan

  • - added unit tests

@github-actions
Copy link

github-actions bot commented May 8, 2023

The mobile version of example app from this branch is ready! You can see it here.

Copy link
Contributor

@gedu gedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukewalczak lukewalczak merged commit 2c25126 into main May 15, 2023
@lukewalczak lukewalczak deleted the fix/touchable-ripple-underlay-view branch May 15, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants