fix: demo app tweaks #3821
Merged
fix: demo app tweaks #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjaniczek
approved these changes
Apr 17, 2023
|
The mobile version of example app from this branch is ready! You can see it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adding
unstable_pressDelay- there is an issue withreact-nativerelated to detecting gestures, especially when it comes to scrolling the list with touchables – when a user tries to scroll a list, the system may mistakenly detect it as a tap or swipe gesture, which can lead to unexpected behaviour.correct
inputReducer- avoid modifying the state, which is again the principles of immutabilityRelated issue
Test plan
Testing on the physical device, on both platforms.