Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync TouchableRipple prop types #3735

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Conversation

DimitarNestorov
Copy link
Contributor

@DimitarNestorov DimitarNestorov commented Mar 8, 2023

Summary

Fixes #3732
Adds "moduleSuffixes": [".android", ".native", ".ios", ""] to tsconfig and fixes errors.

Test plan

yarn typescript doesn't fail

@callstack-bot
Copy link

Hey @DimitarNestorov, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

The mobile version of example app from this branch is ready! You can see it here.

@lukewalczak lukewalczak merged commit d2432f1 into main Mar 13, 2023
@lukewalczak lukewalczak deleted the fix/touchableripple-types branch March 13, 2023 19:06
@younes0
Copy link

younes0 commented Mar 13, 2023

thanks @lukewalczak @DimitarNestorov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typescript error Property 'theme' is missing
4 participants