Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed accessibility label based on onPress callback #3719

Merged
merged 1 commit into from
Mar 6, 2023
Merged

fix: changed accessibility label based on onPress callback #3719

merged 1 commit into from
Mar 6, 2023

Conversation

barttom
Copy link
Contributor

@barttom barttom commented Mar 2, 2023 •
edited
Loading

Summary

Resolves problem for accessibility label when Appbar.Content has no OnPress action
detailed info: #3704

Test plan

  • Start the app
  • Open Xcode, then go to the Xcode menu -> Open Developer Tool -> Accessibility Inspector
  • Select the heading
case expected result
when Appbar.Content hasn't onPress callback: content is recognized as a text image
when Appbar.Content has onPress callback: component is recognized as a button image

|

@barttom barttom requested a review from lukewalczak March 2, 2023 19:36
@callstack-bot
Copy link

Hey @barttom, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

lukewalczak
lukewalczak approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@lukewalczak lukewalczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @barttom for applying the fix! 🔥

@lukewalczak lukewalczak added this to the 5.3.0 milestone Mar 2, 2023
@lukewalczak lukewalczak merged commit 2f8a86f into callstack:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukewalczak lukewalczak lukewalczak approved these changes

Assignees
No one assigned
Labels
Accessibility Appbar
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@barttom @callstack-bot @lukewalczak