Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust surface wrapper opacity #3709

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

lukewalczak
Copy link
Member

Fixes: #3703

Summary

According to the issue, PR adjusts the opacity of the Banner component, to set it to 0 once the component is not visible.

Related issue:

Test plan

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here.

@lukewalczak lukewalczak added this to the 5.3.0 milestone Feb 27, 2023
@Ross-Landry
Copy link

@lukewalczak Elegant solution! Thank you very much for taking the time

@lukewalczak lukewalczak merged commit 5c31ef9 into main Mar 6, 2023
@lukewalczak lukewalczak deleted the fix/banner-visibility branch March 6, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Banner border still visible when the banner is hidden
3 participants