feat: Add onClearIconPress to SearchBar #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0tl3ss
force-pushed
the
main
branch
2 times, most recently
from
1f3345d to
d864c27
Compare
n0tl3ss
force-pushed
the
main
branch
3 times, most recently
from
af701c0 to
fab09fe
Compare
lukewalczak
requested changes
Feb 19, 2023
| root.current?.clear(); | ||
| rest.onChangeText?.(''); | ||
| onClearIconPress?.(e); |
There was a problem hiding this comment.
In order to accept the PR please add an unit test confirming that onClearIconPress is called when clear button is pressed
|
Hi @lukewalczak thanks for your reply. Sorry for late response I was on vacation. I think now everything is ready. |
|
Hey @n0tl3ss, thanks for PR adjustments. Please correct the commit message in order to merge it (according to the contribution guide). |
|
Hi, @lukewalczak. Is commit message now ok? :) |
lukewalczak
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Thanks @n0tl3ss for addressing the feedback and adding a new functionality!
|
The commit message is still not correct, it should be |
n0tl3ss
changed the title
|
@lukewalczak I think now commit and title of PR is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
onClearIconPressprop to theSearchbarcomponent. IfonClearIconPressis defined when pressing close button on search the default behaviour will be executed and after that users' hook will be executed. This for an example allowsKeyboard.dismiss()to be called from hook.Test plan
There is no visually changes. Adding
onClearIconPress={() => /* delete query text (default behaviour) and dismiss keyboard */ Keyboard.dismiss()}toSearchBarshould dismiss keyboard after clearing text.This feature was requested in #1970