fix: calls onLayout on input affix #3597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here. |
brunohkbx
approved these changes
Jan 16, 2023
|
Thanks for looking into this. Would it be backported to 4.x? |
Hey @mfds, it won't be, we are not planning to release patches for v4 anymore. |
lukewalczak
force-pushed
the
fix/input-affix-on-layout
branch
from
35ef79a to
012748d
Compare
|
Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes missing possibility to invoke
onLayoutonTextInput.Affixwhich is mentioned in the documentation.Related issue
TextInput.AffixproponLayoutis not passed to component #3589Test plan
Added unit test.