feat: make onDismiss optional on Menu #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here |
|
wow very cool, not only you responded to my issue but made a pr yourself! first time I see this in opensource ❤ though I think it's because you're getting paid for it unlike developers of small libraries |
Thanks!
Actually, I was given dedicated time to maintain the library so I'm doing it during my working hours or in my free time if have the possibility :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3404
Summary
PR makes the
onDismissmethod optional to allow the user to dismiss theMenucomponent by pressing e.g. the menu item and allowing the user to interact with the background at the same time, without hiding theMenu.Test plan
Tested manually on device.