fix: progress bar animated value #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here |
lukewalczak
reviewed
Oct 17, 2022
lukewalczak
reviewed
Oct 17, 2022
|
The mobile version of example app from this branch is ready! You can see it here |
|
The mobile version of example app from this branch is ready! You can see it here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3366
Introduces the
animatedValueprop to allow usage for controlling the progress bar using animated value created by Animated API. This prop is different when compared toprogress, since progress isn't designed to support values that change continuously as it triggers another animation under the hood to populate progress bar. So we allowed the users to pass in their ownanimatedValueto control the progress bar.Test plan
android
android-animated.mp4
iOS
iOS-animated.mp4
web
web-animated.mp4