Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct center-aligned mode in AppbarHeader #3241

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

lukewalczak
Copy link
Member

Summary

PR introduces a fix for center-aligned where the long title was overlapping with the rest of the content.

Before the fix:

Zrzut ekranu 2022-07-5 o 21 41 09

After the fix:

ios one icon ios two icons
Zrzut ekranu 2022-07-5 o 20 37 17 Zrzut ekranu 2022-07-5 o 20 37 14
android one icon android two icons
Zrzut ekranu 2022-07-5 o 20 36 43 Zrzut ekranu 2022-07-5 o 20 37 09

Note: for the shorter title which fits in the header without truncating, with two icons on the right side, the title is a bit left-aligned.

ios one icon ios two icons
Zrzut ekranu 2022-07-5 o 20 37 22 Zrzut ekranu 2022-07-5 o 20 37 25
android one icon android two icons
Zrzut ekranu 2022-07-5 o 20 37 01 Zrzut ekranu 2022-07-5 o 20 36 56

Test plan

Tests updated.

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak merged commit c1b1c58 into main Jul 6, 2022
@lukewalczak lukewalczak deleted the fix/correct-center-aligned-appbar branch July 6, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant