fix: supporting empty labels

[VictorioMolina]

Summary

When using the current TextInputFlat.js, I get the error:

Text strings must be rendered within a component.

which breaks my components tree.

This is how I am using the TextInput component:

<TextInput
  ref={textInputRef}
  label="" <---- Try with an empty label
  placeholder="Enter a description..."
  ...
/>

The problem is in the line 311 of the TextInputFlat.js module. If you just do the following:

{!isAndroid && multiline && Boolean(label) && (

the error disappears.

Test plan

Just pass an empty label to the TextInput component. Something which, in my opinion, should be accepted.

You can also check this little snack, where the current bug is reproduced.

[callstack-bot]

Hey @VictorioMolina, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

[VictorioMolina]

It might not be really useful to support empty labels BTW, but I consider this a bug. Also, notice that you can pass empty placeholders to the current version without getting errors.

[lukewalczak]

Hey @VictorioMolina, does the bug exist on the version 4.12.1?

[VictorioMolina]

@lukewalczak yes.