Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust Card #3158

Merged
merged 8 commits into from
Jun 6, 2022
Merged

feat: adjust Card #3158

merged 8 commits into from
Jun 6, 2022

Conversation

OlimpiaZurek
Copy link
Contributor

Summary

PR:

  • adjust Card into Material You:
  • introduces new mode filled ( without elevation and border),
  • removes elevation from outlined mode
  • moves buttons to right side
  • rounds the corners of the Image

Test plan

  • check application in both them, if Card works and have correct elevation, button placement roundness and color in both themes on both platforms

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@callstack-bot
Copy link

callstack-bot commented Apr 22, 2022

Hey @OlimpiaZurek, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

1 similar comment
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak changed the title feat: adjust card feat: adjust Card Apr 29, 2022
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

1 similar comment
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak marked this pull request as ready for review May 30, 2022 13:28
@Q1w1N Q1w1N self-requested a review May 31, 2022 09:10
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

The mobile version of example app from this branch is ready! You can see it here

.

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

The mobile version of example app from this branch is ready! You can see it here

.

Copy link
Contributor

@Q1w1N Q1w1N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on IOS and Android. Looks good to me :)

@lukewalczak lukewalczak merged commit 8d3e7a2 into next Jun 6, 2022
lukewalczak pushed a commit that referenced this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants