fix: controlled text input #3145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to keep track of value state internally when component is controlled and value is received as prop (state is in parent component).
|
Hey @seahorsepip, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
drplauska
reviewed
Apr 13, 2022
lukewalczak
reviewed
Apr 22, 2022
Co-authored-by: Luke Walczak <[email protected]>
lukewalczak
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use value from props instead of local state for controlled
TextInput.Summary
See #3144
Test plan
Test both a controlled and non controlled input, check if value shown in input is correct.