Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adjust Button #3114

Merged
merged 7 commits into from
May 27, 2022
Merged

feat: adjust Button #3114

merged 7 commits into from
May 27, 2022

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Mar 8, 2022 •
edited
Loading

Summary

PR:

  • adjusts Button into Material You.
  • introduces two new modes: 'elevated' and 'contained-tonal' - along with theme version 3, contained button doesn't have elevation, so suggesting to use elevated
  • deprecated color prop and introduces instead textColor and buttonColor

Test plan

  • check application in both themes, if Button works and have correct colors in both themes on both platforms
  • snapshots indicate that Button from theme version 2 wasn't changed.

@callstack-bot
Copy link

callstack-bot commented Mar 8, 2022 •
edited
Loading

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak changed the title feat: adjust button feat: adjust Button Mar 23, 2022
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak marked this pull request as ready for review March 26, 2022 13:18
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

1 similar comment
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

Drakeoon
Drakeoon suggested changes May 11, 2022
View reviewed changes
src/components/Button/helpers.tsx Outdated Show resolved Hide resolved
@lukewalczak lukewalczak added wip and removed wip labels May 11, 2022
@lukewalczak lukewalczak force-pushed the feat/adjust-button branch from e76c99c to 734cbe7 Compare May 12, 2022 14:51
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

1 similar comment
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak force-pushed the feat/adjust-button branch from 734cbe7 to 21acd62 Compare May 15, 2022 18:12
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak merged commit 15fcd48 into next May 27, 2022
@lukewalczak lukewalczak deleted the feat/adjust-button branch May 27, 2022 10:23
lukewalczak added a commit that referenced this pull request Jun 8, 2022
@lukewalczak
feat: adjust Button (#3114)
95c083f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drakeoon Drakeoon Drakeoon approved these changes

@OlimpiaZurek OlimpiaZurek OlimpiaZurek approved these changes

Assignees
No one assigned
Labels
Button Material You (v5)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukewalczak @callstack-bot @OlimpiaZurek @Drakeoon