feat: introduce new prop labelMaxFontSizeMultiplier for BottomNavigation #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 23, 2022
|
The mobile version of example app from this branch is ready! You can see it here |
|
Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
The mobile version of example app from this branch is ready! You can see it here |
jaworek
approved these changes
Mar 9, 2022
dratwas
reviewed
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3099
Summary
PR introduces new prop for
BottomNavigationcalledlabelMaxFontSizeMultiplierwhich specifies the largest possible scale a label font can reach in the similar way as rn text prop maxFontSizeMultipliersTest plan
labelMaxFontSizeMultiplier={2}labelMaxFontSizeMultiplier={1}