Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adjust Dialog components, introduce DialogIcon #3079

Merged
merged 8 commits into from
May 23, 2022
Merged

feat: adjust Dialog components, introduce DialogIcon #3079

merged 8 commits into from
May 23, 2022

Conversation

lukewalczak
Copy link
Member

Summary

PR:

  • adjusts Dialog components to Material You
  • introduces DialogIcon component

Test plan

@lukewalczak lukewalczak force-pushed the feat/adjust-dialog-component branch from a3a0bde to b679de6 Compare February 6, 2022 17:58
@callstack-bot
Copy link

callstack-bot commented Feb 6, 2022 •
edited
Loading

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@lukewalczak lukewalczak force-pushed the feat/adjust-dialog-component branch from b679de6 to 91084ce Compare March 10, 2022 14:52
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak force-pushed the feat/adjust-dialog-component branch 2 times, most recently from d40a96e to 4f75547 Compare March 27, 2022 10:25
@lukewalczak lukewalczak marked this pull request as ready for review March 27, 2022 10:25
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

2 similar comments
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@github-actions
Copy link

github-actions bot commented May 2, 2022

The mobile version of example app from this branch is ready! You can see it here

.

1 similar comment
@github-actions
Copy link

github-actions bot commented May 4, 2022

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak force-pushed the feat/adjust-dialog-component branch from c3f19fd to 2e13597 Compare May 4, 2022 17:50
@github-actions
Copy link

github-actions bot commented May 4, 2022

The mobile version of example app from this branch is ready! You can see it here

.

1 similar comment
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak force-pushed the feat/adjust-dialog-component branch from fd62ec2 to 4c94d23 Compare May 23, 2022 12:31
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@Q1w1N Q1w1N self-requested a review May 23, 2022 12:52
Q1w1N
Q1w1N approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@Q1w1N Q1w1N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@lukewalczak lukewalczak merged commit e5dbcb6 into next May 23, 2022
@lukewalczak lukewalczak deleted the feat/adjust-dialog-component branch May 23, 2022 20:40
lukewalczak added a commit that referenced this pull request Jun 8, 2022
@lukewalczak
feat: adjust Dialog components, introduce DialogIcon (#3079)
9e9654b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Q1w1N Q1w1N Q1w1N approved these changes

@jaworek jaworek jaworek approved these changes

Assignees
No one assigned
Labels
Dialog Material You (v5)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukewalczak @callstack-bot @jaworek @Q1w1N