Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adjust Appbar components into Material You #3076

Merged
merged 11 commits into from
May 11, 2022
Merged

feat: adjust Appbar components into Material You #3076

merged 11 commits into from
May 11, 2022

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Feb 4, 2022 •
edited
Loading

Summary

PR:

  • adjusts Appbar and its subcomponents to Material You.
  • introduces new props:
    • mode: 'small' (default) | 'medium' | 'large' | 'center-aligned'
    • elevated - adding shadow

iOS

light theme
small medium large center-aligned
Zrzut ekranu 2022-02-4 o 12 18 06 Zrzut ekranu 2022-02-4 o 12 18 11 Zrzut ekranu 2022-02-4 o 12 18 15 Zrzut ekranu 2022-02-4 o 12 18 19
dark theme
small medium large center-aligned
Zrzut ekranu 2022-02-4 o 12 19 45 Zrzut ekranu 2022-02-4 o 12 19 48 Zrzut ekranu 2022-02-4 o 12 19 51 Zrzut ekranu 2022-02-4 o 12 19 54

Android

light theme
small medium large center-aligned
Zrzut ekranu 2022-02-4 o 12 44 45 Zrzut ekranu 2022-02-4 o 12 44 50 Zrzut ekranu 2022-02-4 o 12 46 38 Zrzut ekranu 2022-02-4 o 12 46 43
dark theme
small medium large center-aligned
Zrzut ekranu 2022-02-4 o 12 48 29 Zrzut ekranu 2022-02-4 o 12 48 34 Zrzut ekranu 2022-02-4 o 12 48 39 Zrzut ekranu 2022-02-4 o 12 48 45

Test plan

@lukewalczak lukewalczak force-pushed the feat/adjust-appbar-components branch from 65bef5a to 679b4ab Compare February 4, 2022 10:31
@callstack-bot
Copy link

callstack-bot commented Feb 4, 2022 •
edited
Loading

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@lukewalczak lukewalczak force-pushed the feat/adjust-appbar-components branch from 7ad9b95 to 95cbea6 Compare February 10, 2022 22:29
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak force-pushed the feat/adjust-appbar-components branch from 95cbea6 to 65ad785 Compare March 9, 2022 12:03
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

The mobile version of example app from this branch is ready! You can see it here

.

1 similar comment
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak force-pushed the feat/adjust-appbar-components branch from 399a180 to a1573e2 Compare March 21, 2022 19:40
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak force-pushed the feat/adjust-appbar-components branch from a1573e2 to 21e652f Compare March 27, 2022 18:28
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

2 similar comments
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak marked this pull request as ready for review April 14, 2022 16:24
Drakeoon
Drakeoon suggested changes May 11, 2022
View reviewed changes
Copy link
Contributor

@Drakeoon Drakeoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me, I've pointed out to one util refactor that you can consider applying

src/components/Appbar/utils.ts Outdated Show resolved Hide resolved
@lukewalczak lukewalczak force-pushed the feat/adjust-appbar-components branch from 6ea6fa4 to 423311b Compare May 11, 2022 08:30
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak changed the title feat: adjust Appbar components feat: adjust Appbar components into Material You May 11, 2022
@lukewalczak lukewalczak merged commit c89eae8 into next May 11, 2022
@lukewalczak lukewalczak deleted the feat/adjust-appbar-components branch May 11, 2022 11:55
lukewalczak added a commit that referenced this pull request Jun 8, 2022
@lukewalczak @Drakeoon
feat: adjust Appbar components into Material You (#3076)
c0f5007 
Co-authored-by: Daniel Szczepanik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drakeoon Drakeoon Drakeoon approved these changes

Assignees
No one assigned
Labels
Appbar Material You (v5)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukewalczak @callstack-bot @Drakeoon