feat: replace old variable references #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here |
Drakeoon
force-pushed
the
feat/replace-old-variable-references
branch
from
0ee879d to
d3d2bb5
Compare
|
The mobile version of example app from this branch is ready! You can see it here |
lukewalczak
reviewed
Jan 31, 2022
lukewalczak
reviewed
Jan 31, 2022
| @@ -117,10 +115,10 @@ const AnimatedFABExample = () => { | |||
| keyExtractor={_keyExtractor} | |||
| onEndReachedThreshold={0} | |||
| scrollEventThrottle={16} | |||
| style={[styles.flex, { backgroundColor: background }]} | |||
| style={[styles.flex, { backgroundColor: colors?.background || '#000' }]} | |||
There was a problem hiding this comment.
As we discussed internally, fallback colors are temporary to not block the PR. All the cases will be refactored in the way: isV3 ? appropriate color from V3 : appropriate color from V2
|
The mobile version of example app from this branch is ready! You can see it here |
lukewalczak
pushed a commit
that referenced
this pull request
Mar 22, 2022
lukewalczak
pushed a commit
that referenced
this pull request
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These changes fix other parts of application when theme V3 would be used instead of V2. Changes:
colors.background, were replaced with optional chaining or dirty defaults (to be resolved later on, during the works on individual components)