-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update material you theming #3053
Conversation
The mobile version of example app from this branch is ready! You can see it here |
@@ -25,29 +25,114 @@ export type Fonts = { | |||
|
|||
type Mode = 'adaptive' | 'exact'; | |||
|
|||
export type Theme = { | |||
export type Material2Colors = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Total nitpick 🤏 -> if you have MD3Color
maybe you should also have MD2Color
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, definitely. Will talk this through with Luke, as we typically exposed a clean Theme interface and now we would have some conditional types - it will get changed pretty soon, good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
I personally appreciate the most the backwards compatibility 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the code perspective LGTM 🎉 ! I'm planning to run it on devices as well soon.
@lukewalczak I implemented the requested changes. Unfortunately one change is affects the major part of our codebase and causes the build to be red. I suggest creating a separate PR that fixes the build, as there are more than 80 components that need to be adjusted |
@Drakeoon, make sense, let's merge that PR and iterate with fixing build on the next one. |
Summary
We're officially starting the works with Material 3! 🎉 (Material You)
A more detailed description will probably appear on the
next
branch quite soonThe following changes were done:
md()
helper that can be used with Material 3 tokens -md('md.ref.palette.tertiary90') -> #FFD8E4
Test plan
As of now, the changes aren't affecting the app. Each PR that covers new components' support will have it's own preview and testing plans