Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chip styles #2959

Closed
root-io opened this issue Nov 5, 2021 · 6 comments
Closed

Chip styles #2959

root-io opened this issue Nov 5, 2021 · 6 comments

Comments

@root-io
Copy link

root-io commented Nov 5, 2021

Current behaviour

The size of the 3 chips in my example are shrink, we can't see the text

Expected behaviour

The size of the 3 chips in my example should display a full height

Code sample

import * as React from 'react';
import { View, StyleSheet } from 'react-native';
import { Chip, List } from 'react-native-paper';

const ChipExample = () => {
  return (
    <>
      <List.Section title="Flat chip">
        <View style={styles.row}>
          <Chip selected onPress={() => { }} style={styles.chip}>
            Simple 1
          </Chip>
          <Chip selected onPress={() => { }} style={styles.chip}>
            Simple 2
          </Chip>
          <Chip selected onPress={() => { }} style={styles.chip}>
            Simple 3
          </Chip>
        </View>
      </List.Section>
    </>
  );
};

const styles = StyleSheet.create({
  row: {
    flexDirection: 'row',
    flexWrap: 'wrap',
    paddingHorizontal: 12,
  },
  chip: {
    margin: 4,
  },
});

export default ChipExample;

Screenshots (if applicable)

screenshot

What have you tried

Broken since 4.10.0, was working as expected in 4.9.2

Your Environment

software version
android 12
react-native 0.66.2
react-native-paper 4.10.0
node 16.13.0
npm 8.1.0
expo sdk no
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

Couldn't find version numbers for the following packages in the issue:

  • react-native-vector-icons
  • expo

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

The versions mentioned in the issue for the following packages differ from the latest versions on npm:

  • npm (found: 8.1.0, latest: 8.1.3)

Can you verify that the issue still exists after upgrading to the latest versions of these packages?

@github-actions
Copy link

github-actions bot commented Nov 5, 2021

Hey! Thanks for opening the issue. The issue doesn't seem to contain a link to a repro (a snack.expo.io link or link to a GitHub repo under your username).

Can you provide a minimal repro which demonstrates the issue? A repro will help us debug the issue faster. Please try to keep the repro as small as possible and make sure that we can run it without additional setup.

@lukewalczak
Copy link
Member

Hello @root-io, please put your bug reproduction on snack

@jvincent-dev
Copy link

jvincent-dev commented Nov 5, 2021

Hello @root-io, please put your bug reproduction on snack

I added his code to a snack but changed the color of the Chip to make it more visible here

edit: having the same issue btw.

@lukewalczak
Copy link
Member

Thanks, I will be working on the fix in the upcoming days!

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

Hello 👋, this issue has been open for more than a month without a repro or any activity. If the issue is still present in the latest version, please provide a repro or leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution or workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants