-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use theme colors in Banner #2932
Conversation
fix: remove redundant array
The mobile version of example app from this branch is ready! You can see it here |
Hey @haxonadora, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
The mobile version of example app from this branch is ready! You can see it here |
Hey @haxonadora thanks for the PR! Could you please replace one of the button in |
Great idea @lukewalczak. I changed |
The mobile version of example app from this branch is ready! You can see it here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @haxonadora for your work!
Summary
Closes #2899
Currently theme prop passed to Banner is only used for
scale
property. Users can't change banner colors such assurface
,primary
ortext
by providing custom theme prop. This PR uses colors provided by theme props to style Banner inner componentsTest plan
surface
,primary
,text
)