fix: add missing padding to CardTitle #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here |
satya164
approved these changes
Jul 29, 2021
lukewalczak
reviewed
Jul 29, 2021
brunohkbx
force-pushed
the
fix/add-missing-padding
branch
from
333de6a to
233c783
Compare
|
Hey @brunohkbx, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
brunohkbx
force-pushed
the
fix/add-missing-padding
branch
from
233c783 to
138e293
Compare
allforabit
added a commit
to nearform/optic-expo
that referenced
this pull request
Nov 16, 2021
allforabit
added a commit
to nearform/optic-expo
that referenced
this pull request
Nov 16, 2021
* chore(deps): bump react-native-paper from 4.9.2 to 4.10.0 Bumps [react-native-paper](https://github.com/callstack/react-native-paper) from 4.9.2 to 4.10.0. - [Release notes](https://github.com/callstack/react-native-paper/releases) - [Changelog](https://github.com/callstack/react-native-paper/blob/main/.release-it.json) - [Commits](callstack/react-native-paper@v4.9.2...v4.10.0) --- updated-dependencies: - dependency-name: react-native-paper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * test: update snapshots to allow for paddingRight fix in react-native-paper callstack/react-native-paper#2830 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin Nolan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I just realized that in the Card.Title paddingRight was missing. So the title was a little bit off when centered.
Test plan