Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve ListAccordion accessibility #2775

Merged
merged 1 commit into from
Jul 29, 2021
Merged

feat: improve ListAccordion accessibility #2775

merged 1 commit into from
Jul 29, 2021

Conversation

brunohkbx
Copy link
Collaborator

Summary

  1. Add prop accessibilityLabel to ListAccordion
  2. Pass the key expanded under accessibilityState to the TouchableRipple

Test plan

  1. Test it using TalkBack or VoiceOver

@brunohkbx brunohkbx requested a review from lukewalczak June 15, 2021 18:43
@callstack-bot
Copy link

Hey @brunohkbx, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@brunohkbx brunohkbx merged commit adc65b3 into main Jul 29, 2021
@brunohkbx brunohkbx deleted the feat/improve-ListAccordion-accessibility branch July 29, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukewalczak lukewalczak lukewalczak approved these changes

@satya164 satya164 satya164 approved these changes

Assignees
No one assigned
Labels
Accessibility List
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brunohkbx @callstack-bot @satya164 @lukewalczak