Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-Native 0.61.x #1341

Closed
marcorm opened this issue Sep 21, 2019 · 13 comments
Closed

React-Native 0.61.x #1341

marcorm opened this issue Sep 21, 2019 · 13 comments

Comments

@marcorm
Copy link

marcorm commented Sep 21, 2019

Environment

Android API Level 26
RN 0.61.x
react-native-paper stable and alpha

Description

I noticed a problem with react-native-paper and react-native 0.61.x on Android API Level 26.
Doesn't happen on API Level 23 or 29.

When i open a Dialog inside a Portal it shows up weird.
Same problem with FAB.

The problem doesn't arise with RN 0.60.5.
It happens with the last versions of react-native-paper (stable and alpha).

Here are two attachments showing the issue:
RN 0.60.5

RN 0.61.x

P.S. don't pay attention to Icons in the bottom tab.

Reproducible Demo

Just start a new project with RN 0.61.x and put a FAB or a Portal inside it with react-native 0.61.x on Android API Level 26.

EDIT: Repository to reproduce the issue

P.S. I don't know if its RN issue or a RNP issue.
I also posted it here:
react-native-community/releases#140 (comment)

@alradadi
Copy link

running into the same issue on Android

@marcorm
Copy link
Author

marcorm commented Sep 23, 2019

I found out something: putting a normal Button (from react-native) inside the Dialog (instead of react-native-paper Button) fixes the issue.
EDIT: i created this repo to reproduce the issue with minimal code:
https://github.com/marcorm/rn061_rnp_issue/tree/master

@marcorm
Copy link
Author

marcorm commented Sep 24, 2019

I know it's not a react-native-paper issue but, as stated here setting borderRadius to undefined solves the problem.

@Ludus-Team
Copy link

It's not just on dialog, it's happen on Android with elevation View (Upgrade to 0.61.0 and still the same problem)

With 0.60.5:
Screenshot_1569395991

With 0.61.0:
Screenshot_1569396036

@usmansbk
Copy link

usmansbk commented Sep 25, 2019

Facing the same problem with Fab

@gdoudeng
Copy link

I am facing this problem and hope to solve it as soon as possible.

@carlosroberto555
Copy link

+1 Same issue with FAB

@satya164
Copy link
Member

satya164 commented Oct 2, 2019

facebook/react-native#26682

@satya164
Copy link
Member

satya164 commented Oct 2, 2019

Fixed in RN 0.61.2 https://github.com/facebook/react-native/releases/tag/v0.61.2

@satya164 satya164 closed this as completed Oct 2, 2019
@marcorm
Copy link
Author

marcorm commented Oct 2, 2019

Great

@deadcoder0904
Copy link

Hey, @satya164 I am still getting this error. I'm on v0.61.2 👇

bug icon

I've also opened an issue on RN 👉facebook/react-native#26740 which contains the repro steps

@zcmgyu
Copy link

zcmgyu commented Mar 21, 2020

Confirmed still get the error on React Native 0.61.5

@todorone
Copy link

@satya164 This issue is still around with latest RN versions, please reopen it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests