Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked / not linked groups #17

Open
gawrysiak opened this issue Mar 1, 2019 · 3 comments
Open

Linked / not linked groups #17

gawrysiak opened this issue Mar 1, 2019 · 3 comments

Comments

@gawrysiak
Copy link
Contributor

There's no way to tell which group header is clickable. In this example, you can click on Appbar and it opens the proper docs page, while clicking Avatar makes the section collapse. This makes it harder to just go through the docs.

It could either have some visual indication or maybe open the first sublink by default?

Other than that, great work with the recent changes. It really improved visually 👍

screen shot 2019-03-01 at 20 19 34

@satya164
Copy link
Member

Do you have any ideas on how to style them?

@gawrysiak
Copy link
Contributor Author

Trying to style it might be the hardest way to handle it, I can't recall seeing it handled this way anywhere. But there's some other solutions that could work:

  • keep the non-clickable groups collapsed by default - this way the initial click moves you further suggesting to click the sublinks instead of hiding them
  • make it open the first sublink on group click
  • create extra doc pages for the non-clickable groups with an overview of the inside components (links to components, screenshots, some descriptions)

As for the styling ideas, the only one I can think of now is placing some extra "component" icon to distinguish components from empty links or description pages

@satya164
Copy link
Member

I think the second solution will be the easiest option.

There are some more reason groups aren't collapsed by default 1) The pages work without JS, 2) We need to measure the height so they need to be not collapsed (not sure about this one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants