Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valueCount(nil) should be valueCount(0) #5

Open
warpling opened this issue Mar 3, 2015 · 8 comments
Open

valueCount(nil) should be valueCount(0) #5

warpling opened this issue Mar 3, 2015 · 8 comments

Comments

@warpling
Copy link

warpling commented Mar 3, 2015

The following line (53 in POPPropertyAnimationInternal.h) causes an error

 _POPPropertyAnimationState(id __unsafe_unretained anim) : _POPAnimationState(anim),
 ...
 valueCount(nil),
 ...

I believe the fix is as simple as changing it to valueCount(0), but maybe I'm overlooking something.

@warpling
Copy link
Author

warpling commented Mar 3, 2015

Full error: /Users/ryanmcleod/Code/pop-playground-master/Pods/pop/pop/POPPropertyAnimationInternal.h:53:3: Cannot initialize a member subobject of type 'NSUInteger' (aka 'unsigned long') with an rvalue of type 'nullptr_t'

@nickbewley
Copy link

I got the same error. Anyone have an idea?

@warpling
Copy link
Author

warpling commented Mar 4, 2015

Replacing it with '0' seems to be okay.

On Wed, Mar 4, 2015 at 11:55 AM, Nick Bewley [email protected]
wrote:

I got the same error. Anyone have an idea?

Reply to this email directly or view it on GitHub:
#5 (comment)

@natemcguire
Copy link

Same error here, replacing with 0 seems to work

@Francescu
Copy link
Collaborator

Could someone PR?

Thanks

@warpling
Copy link
Author

It appears this got fixed in Pop awhile back, that said I just cloned this repo fresh and was able to build without issue? If you're still having it though, perhaps you could pod update and pod install?

@Francescu
Copy link
Collaborator

Ok I updated the podlock


Sent from Mailbox

On Mon, May 18, 2015 at 5:02 PM, Ryan McLeod [email protected]
wrote:

It appears this got fixed in Pop awhile back, that said I just cloned this repo fresh and was able to build without issue? If you're still having it though, perhaps you could pod update and pod install?

Reply to this email directly or view it on GitHub:
#5 (comment)

@warpling
Copy link
Author

👍

On Mon, May 18, 2015 at 3:21 PM, Francescu Santoni
[email protected] wrote:

Ok I updated the podlock

Sent from Mailbox
On Mon, May 18, 2015 at 5:02 PM, Ryan McLeod [email protected]
wrote:

It appears this got fixed in Pop awhile back, that said I just cloned this repo fresh and was able to build without issue? If you're still having it though, perhaps you could pod update and pod install?

Reply to this email directly or view it on GitHub:

#5 (comment)

Reply to this email directly or view it on GitHub:
#5 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants