Skip to content

Commit

Permalink
flutter: strings: Change Hint to Info
Browse files Browse the repository at this point in the history
Thanks Matt Littlewood!
Feedback: What does the hint button do? I dont see the hint.
  • Loading branch information
calcitem committed May 14, 2021
1 parent bec4e57 commit d19b70e
Show file tree
Hide file tree
Showing 24 changed files with 15 additions and 10 deletions.
Binary file modified fastlane/metadata/android/en-US/images/phoneScreenshots/1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified fastlane/metadata/android/en-US/images/phoneScreenshots/2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified fastlane/metadata/android/en-US/images/phoneScreenshots/3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified fastlane/metadata/android/en-US/images/tenInchScreenshots/1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified fastlane/metadata/android/en-US/images/tenInchScreenshots/2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified fastlane/metadata/android/en-US/images/tenInchScreenshots/3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion fastlane/metadata/android/en-US/video.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
https://www.youtube.com/watch?v=AFN_NOKvzL4
https://www.youtube.com/watch?v=jRDrnMFWjSU
Binary file modified fastlane/metadata/android/zh-CN/images/phoneScreenshots/1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified fastlane/metadata/android/zh-CN/images/phoneScreenshots/2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified fastlane/metadata/android/zh-CN/images/phoneScreenshots/3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified fastlane/metadata/android/zh-CN/images/tenInchScreenshots/1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified fastlane/metadata/android/zh-CN/images/tenInchScreenshots/2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified fastlane/metadata/android/zh-CN/images/tenInchScreenshots/3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion fastlane/metadata/android/zh-CN/video.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
https://www.youtube.com/watch?v=AFN_NOKvzL4
https://www.youtube.com/watch?v=jRDrnMFWjSU
4 changes: 4 additions & 0 deletions src/ui/flutter_app/lib/l10n/intl_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,10 @@
"@pick": {
"description": "Pick "
},
"info": "Info",
"@info": {
"description": "Info"
},
"hint": "Hint",
"@hint": {
"description": "Hint"
Expand Down
1 change: 1 addition & 0 deletions src/ui/flutter_app/lib/l10n/intl_zh.arb
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@
"exitApp": "App 将退出。",
"exitAppManually": "您需要立即退出并重新打开本程序才能使默认配置生效。",
"pick": "选择",
"info": "信息",
"hint": "提示",
"player": "玩家",
"player1": "先手方",
Expand Down
4 changes: 2 additions & 2 deletions src/ui/flutter_app/lib/style/app_theme.dart
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ class AppTheme {
static var toolbarTextColor = toolbarIconColor;
static var moveHistoryTextColor = Colors.yellow;
static var moveHistoryDialogBackgroundColor = Colors.transparent;
static var hintDialogackgroundColor = moveHistoryDialogBackgroundColor;
static var hintTextColor = moveHistoryTextColor;
static var infoDialogackgroundColor = moveHistoryDialogBackgroundColor;
static var infoTextColor = moveHistoryTextColor;
static var simpleDialogOptionTextColor = appPrimaryColor;

/// Settings page
Expand Down
12 changes: 6 additions & 6 deletions src/ui/flutter_app/lib/widgets/game_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ class _GamePageState extends State<GamePage> with RouteAware {
.showSnackBar(SnackBar(content: Text(message)));
}

String getHintText() {
String getInfoText() {
String ret = S.of(context).score +
"\n" +
S.of(context).player1 +
Expand Down Expand Up @@ -796,7 +796,7 @@ class _GamePageState extends State<GamePage> with RouteAware {
Widget createToolbar() {
final manualText = Game.instance.position.manualText;

final analyzeText = getHintText();
final analyzeText = getInfoText();

var newGameButton = TextButton(
child: Column(
Expand Down Expand Up @@ -876,15 +876,15 @@ class _GamePageState extends State<GamePage> with RouteAware {
),
);

var hintButton = TextButton(
var infoButton = TextButton(
child: Column(
// Replace with a Row for horizontal icon + text
children: <Widget>[
Icon(
Icons.lightbulb_outline,
color: AppTheme.toolbarIconColor,
),
Text(S.of(context).hint,
Text(S.of(context).info,
style: TextStyle(color: AppTheme.toolbarTextColor)),
],
),
Expand All @@ -893,7 +893,7 @@ class _GamePageState extends State<GamePage> with RouteAware {
barrierDismissible: true,
builder: (BuildContext context) {
return AlertDialog(
backgroundColor: AppTheme.hintDialogackgroundColor,
backgroundColor: AppTheme.infoDialogackgroundColor,
content: SingleChildScrollView(
child: Text(analyzeText, style: AppTheme.moveHistoryTextStyle)),
actions: <Widget>[
Expand Down Expand Up @@ -923,7 +923,7 @@ class _GamePageState extends State<GamePage> with RouteAware {
Expanded(child: SizedBox()),
moveHistoryButton,
Expanded(child: SizedBox()), //dashboard_outlined
hintButton,
infoButton,
Expanded(child: SizedBox()),
]),
);
Expand Down

0 comments on commit d19b70e

Please sign in to comment.