chore(pre-commit): autoupdate hooks #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?s=60&v=4){kind=small}
Coverage report
This PR does not seem to contain any modification to coverable code. |
thekaveman
requested changes
Oct 8, 2024
.pre-commit-config.yaml
Outdated
| @@ -10,8 +10,7 @@ default_install_hook_types: | |||
|
|
|||
| # by default, confine hooks to these git stages (except for hooks that specify their own stages) | |||
| # https://pre-commit.com/#top_level-default_stages | |||
| default_stages: | |||
| - commit | |||
| default_stages: [commit-msg] | |||
There was a problem hiding this comment.
I think we probably want pre-commit here as the default?
angela-tran
reviewed
Oct 8, 2024
machikoyasuda
force-pushed
the
pre-commit-ci-update-config
branch
from
b94c4a1 to
58f8f45
Compare
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
58f8f45 to
f8215c3
Compare
|
These are the warnings that appear on the Running the postAttachCommand from devcontainer.json...
[1610 ms] Start: Run in container: /bin/bash .devcontainer/postAttach.sh
+ git config --global --add safe.directory /usr/src/calitp
+ pre-commit install --install-hooks --overwrite
[WARNING] top-level `default_stages` uses deprecated stage names (commit) which will be removed in a future version. run: `pre-commit migrate-config` to automatically fix this.
pre-commit installed at .git/hooks/pre-commit
pre-commit installed at .git/hooks/commit-msg
[WARNING] top-level `default_stages` uses deprecated stage names (commit) which will be removed in a future version. run: `pre-commit migrate-config` to automatically fix this.
+ pre-commit install --hook-type commit-msg
pre-commit installed at .git/hooks/commit-msg
Done. Press any key to close the terminal.To double-check the configs, I ran the root@e332e85f3af6:/usr/src/calitp# pre-commit migrate-config
Configuration is already migrated. |
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
f8215c3 to
71c7772
Compare
|
@angela-tran This ticket is finally ready for re-review. To refresh your memory, here's how we fixed it in Benefits: https://github.com/cal-itp/benefits/blob/f0687daca8b89544d4caeea8f6658555aa9f2393/.pre-commit-config.yaml#L8 |
|
Set auto-merge on this PR |
angela-tran
previously approved these changes
Oct 30, 2024
There was a problem hiding this comment.
This looks good to me. We'll need @thekaveman 's approval too
thekaveman
requested changes
Oct 31, 2024
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
ccd1340 to
68a46c7
Compare
updates: - [github.com/compilerla/conventional-pre-commit: v3.4.0 → v3.6.0](compilerla/conventional-pre-commit@v3.4.0...v3.6.0) - [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) - [github.com/psf/black: 24.8.0 → 24.10.0](psf/black@24.8.0...24.10.0) - [github.com/igorshubovych/markdownlint-cli: v0.42.0 → v0.43.0](igorshubovych/markdownlint-cli@v0.42.0...v0.43.0)
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
68a46c7 to
2453ae1
Compare
thekaveman
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates: