Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devcontainer): configure git to install pre-commit #474

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

machikoyasuda
Copy link
Member

fixes #473

I followed what @lalver1 did for Benefits here cal-itp/benefits#2027 to fix this bug I got when I loaded the devcontainer on my macOS

@machikoyasuda machikoyasuda requested a review from a team as a code owner July 9, 2024 00:53
@machikoyasuda machikoyasuda self-assigned this Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@machikoyasuda machikoyasuda marked this pull request as draft July 9, 2024 01:13
@machikoyasuda
Copy link
Member Author

Closing this PR for now
Will get back to this after #463 is merged

@thekaveman
Copy link
Member

Oops 😓 I didn't realize we hadn't merged #463 yet!

@thekaveman
Copy link
Member

@machikoyasuda #463 is merged now

@machikoyasuda machikoyasuda reopened this Jul 10, 2024
@machikoyasuda machikoyasuda marked this pull request as ready for review July 10, 2024 16:00
@machikoyasuda machikoyasuda marked this pull request as draft July 10, 2024 16:00
@machikoyasuda machikoyasuda marked this pull request as ready for review July 10, 2024 21:03
@machikoyasuda
Copy link
Member Author

Ready for review now @thekaveman

Re-tested this on rebased branch with the latest from main

@machikoyasuda machikoyasuda merged commit 5e44bd1 into main Jul 10, 2024
6 checks passed
@machikoyasuda machikoyasuda deleted the fix/473-pre-commit branch July 10, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Configure git to install pre-commit
2 participants