Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: custom rule name #341

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix: custom rule name #341

merged 1 commit into from
Oct 3, 2023

Conversation

angela-tran
Copy link
Member

I noticed that our infra pipeline failed to apply the change from #338

The message from the build says:

Error: updating Front Door Firewall Policy: (Front Door Web Application Firewall Policy Name "devwaf" / Resource Group "courtesy-cards-eligibility-dev"): frontdoor.PoliciesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="BadRequest" Message="WebApplicationFirewallPolicy validation failed. More information \"Rule name must start with a letter and contain only numbers and letters\"."

It was my bad on not remembering what characters are allowed in custom rule names when I suggested the name public_access 😓

This PR fixes the name

@angela-tran angela-tran self-assigned this Oct 3, 2023
@angela-tran angela-tran requested a review from a team as a code owner October 3, 2023 20:42
thekaveman
thekaveman approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I didn't notice that, I saw the plan and it looked good so I figured it worked 😓

@angela-tran angela-tran merged commit 9e32f19 into dev Oct 3, 2023
7 checks passed
@angela-tran angela-tran deleted the fix/custom-rule-name branch October 3, 2023 20:50
@angela-tran angela-tran mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@angela-tran angela-tran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angela-tran @thekaveman