Fix: inline expression for deployment environment #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
put the expression back as inline values instead of being a variable
|
Another problem that came out of trying to define and use
(see nektos/act#284 for a past bug that seems similar(?)) Because of this, I wasn't able to make use of Now that I've in-lined the expression, I do get a successful dry run, so that seems promising.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the failed workflow run from when I merged #329 into
dev.It turns out that the
envcontext is not available in the places I wanted to use it (concurrency,jobs.<job>.environment), so in this PR, I put the expression back as inline instead of having it be a variable.See GitHub Actions docs for more on where different contexts are available.