Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add app setting needed to enable GitHub CI/CD webhook #331

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Sep 27, 2023

While trying to show @allejo how our webhook works to push a new Docker image to the Azure app service, we realized "Continuous deployment" was set to off, which seemed odd.

See https://learn.microsoft.com/en-us/azure/app-service/deploy-ci-cd-custom-container?tabs=acr&pivots=container-linux#4-enable-cicd for more details on how that setting works, but basically we realized that the webhook has not been working all this time.

@angela-tran angela-tran requested a review from a team as a code owner September 27, 2023 19:21
@angela-tran angela-tran self-assigned this Sep 27, 2023
@angela-tran angela-tran merged commit eb3a790 into dev Sep 27, 2023
7 checks passed
@angela-tran angela-tran deleted the fix/docker-enable-ci branch September 27, 2023 19:27
@thekaveman thekaveman added the bug Something isn't working label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants