fix(Azure): suppress downtime alerts when data is being loaded #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afeld
commented
Feb 16, 2023
afeld
commented
Feb 16, 2023
| @@ -8,3 +8,27 @@ module "healthcheck" { | |||
| name = "mst-courtesy-cards-eligibility-server-${local.env_name}-healthcheck" | |||
| url = "https://${azurerm_linux_web_app.main.default_hostname}/healthcheck" | |||
| } | |||
|
|
|||
| # ignore when app restarts as data is being reloaded | |||
There was a problem hiding this comment.
Is this only configured on the Velocity side, or somewhere on the Eligibility Server side as well?
|
Unfortunately we won't really know if this works until we merge it and see if an alert comes through overnight 🤷 |
afeld
commented
Feb 16, 2023
| # ignore when app restarts as data is being reloaded | ||
| # https://learn.microsoft.com/en-us/azure/azure-monitor/alerts/alerts-processing-rules | ||
| # the Terraform resource doesn't support time windows, so need to drop down to an ARM template instead | ||
| # https://github.com/hashicorp/terraform-provider-azurerm/issues/16726 |
There was a problem hiding this comment.
See this note re: the JSON above.
afeld
force-pushed
the
fix/suppress-downtime-alerts
branch
from
e582236 to
0c8000d
Compare
afeld
commented
Feb 17, 2023
| } | ||
| ], | ||
| "schedule": { | ||
| "timeZone": "Eastern Standard Time", |
There was a problem hiding this comment.
Created based on grabbing JSON from the Portal, hence it being in my time zone. Didn't bother to change.
angela-tran
approved these changes
Feb 17, 2023
|
Confirmed we're not longer getting the alerts in dev.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #220.
Uses an alert processing rule to disable notifications during that specific window of time every night.