-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize app + Transfer code #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machikoyasuda
force-pushed
the
config/dev-container
branch
from
September 28, 2021 20:19
9485284
to
69f9995
Compare
machikoyasuda
changed the title
WIP - Initialize app
WIP - Initialize app + Transfer code
Sep 29, 2021
machikoyasuda
changed the title
WIP - Initialize app + Transfer code
Initialize app + Transfer code
Sep 29, 2021
thekaveman
requested changes
Sep 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great so far! I was able to get the devcontainer running locally and hit a breakpoint with debug mode active.
I made a few suggestions, nothing major. There was one minor fix to the docs.
thekaveman
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1
closes #3
What this PR does
Dockerfiles
: One for production (Dockerfile
- runs a non-root user, no dev tooling, runs flask app), one for development (Dockerfile.dev
- runs production with a root user, installs dev tooling and python tooling)docker-compose.yml
for development that defines 2 services:server
for production anddev
for development.dev
runsDockerfile.dev
with FLASK environment variables, debugger port defined and runsapp.py
directlydev
service fromdocker-compose.yml
How to run this PR
Initial build
docker-compose build server
Launch in DevContainer + Debug mode
localhost:5000
curl http://localhost:5000/ -iv