Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Azure pipeline approval requirement #370

Closed
thekaveman opened this issue Nov 15, 2023 · 3 comments · Fixed by #477 or #481
Closed

Remove Azure pipeline approval requirement #370

thekaveman opened this issue Nov 15, 2023 · 3 comments · Fixed by #477 or #481
Assignees
Labels
infrastructure Terraform, Azure, etc.

Comments

@thekaveman
Copy link
Member

thekaveman commented Nov 15, 2023

Our Azure DevOps pipeline requires approval for the terraform apply stage.

We added this as part of the refactor towards tag-based deployment. In practice, all engineers are almost always on a call doing the release together, and this approval stage hasn't been necessary or useful.

Let's remove it entirely.

@thekaveman thekaveman added the infrastructure Terraform, Azure, etc. label Nov 15, 2023
@thekaveman thekaveman added this to the SBMTD Mobility Pass milestone Nov 15, 2023
@thekaveman thekaveman moved this from Todo to Stretch in Digital Services Nov 15, 2023
@angela-tran angela-tran self-assigned this Dec 21, 2023
@angela-tran angela-tran moved this from Stretch to In Progress in Digital Services Dec 21, 2023
@angela-tran
Copy link
Member

I was able to install the Azure Pipelines app into Cal-ITP Slack. I signed in to it using my Azure DevOps account. Entering /azpipelines subscribe [pipeline url] gave me back a message of Configuration failed. Please make sure that the organization '*****' exists and that you have sufficient permissions. (***** is where the org name is)

Found from Azure DevOps docs that:

For Azure DevOps, you need to be in the Project Collection Administrators or Project Administrators group to set up a Slack subscription.

@angela-tran angela-tran moved this from In Progress to Todo in Digital Services Dec 21, 2023
@angela-tran angela-tran removed their assignment Dec 21, 2023
@angela-tran angela-tran moved this from Todo to Stretch in Digital Services Dec 21, 2023
@thekaveman thekaveman moved this from Stretch to Paused in Digital Services Mar 13, 2024
@thekaveman thekaveman changed the title Enable Slack notifications for Azure pipeline pending approvals Remove Azure pipeline approval requirement Jun 17, 2024
@thekaveman
Copy link
Member Author

We decided that the pipeline approvals aren't necessary, and removing them will represent a quality of life improvement for engineers. Rewrote this ticket to reflect that.

@thekaveman thekaveman moved this from Paused to Stretch in Digital Services Jun 17, 2024
@angela-tran angela-tran self-assigned this Jul 10, 2024
@angela-tran angela-tran moved this from Stretch to In progress in Digital Services Jul 10, 2024
@angela-tran angela-tran moved this from In progress to In review in Digital Services Jul 10, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Digital Services Jul 11, 2024
@angela-tran
Copy link
Member

Follow-up needed: #480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment