Send logs to Azure Monitor #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
back-end
afeld
commented
Jun 22, 2022
| 1. [Open Application Insights.](https://portal.azure.com/#view/HubsExtension/BrowseResource/resourceType/microsoft.insights%2Fcomponents) | ||
| 1. Click the resource corresponding to the environment. | ||
| 1. In the navigation, under `Monitoring`, click `Logs`. | ||
| 1. In the Query Editor, type `requests` or `traces`, and click `Run`. |
There was a problem hiding this comment.
Seems that traffic logs are sent to the former, stdout/stderr is sent to the latter.
thekaveman
previously approved these changes
Jun 22, 2022
afeld
force-pushed
the
feat/azure-logging
branch
from
5f53549 to
6932fc8
Compare
afeld
commented
Jun 23, 2022
| def test_get_config_with_azure(): | ||
| config = get_config(enable_azure=True) | ||
| assert "azure" in config["handlers"] | ||
| assert "azure" in config["loggers"] |
There was a problem hiding this comment.
Not sure how useful they are, but added tests.
thekaveman
reviewed
Jun 23, 2022
afeld
force-pushed
the
feat/azure-logging
branch
from
6932fc8 to
7e3012e
Compare
thekaveman
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #631. Keeps the logging otherwise the same.
Used the following instructions, to start:
Before merge
APPLICATIONINSIGHTS_CONNECTION_STRINGindevAdded tasks for each environment in #734.