Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Login.gov button design #688

Merged
merged 2 commits into from
Jun 15, 2022
Merged

New Login.gov button design #688

merged 2 commits into from
Jun 15, 2022

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jun 14, 2022 •
edited
Loading

close #653

What this PR does

  • Adds Public Sans font
  • Uses Public Sans font for Get started with text in button
  • Adjust sizes of buttons, alignment, line-height, font on Desktop and Mobile

How to test

  • Test Desktop, Mobile for the Elig Start page
  • Test the Enrollment Success when Logged In and Logged Out pages (because this page also has a Login.gov button) - Ensure no regressions

Button composition

image

image

@machikoyasuda machikoyasuda requested a review from a team as a code owner June 14, 2022 23:39
@github-actions github-actions bot added the deployment-dev [auto] Changes that will trigger a deploy if merged to dev label Jun 14, 2022
thekaveman
thekaveman approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@machikoyasuda machikoyasuda merged commit 5622f9f into dev Jun 15, 2022
@machikoyasuda machikoyasuda deleted the feat/653-login.gov-button branch June 15, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees
No one assigned
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev
Projects
None yet
Milestone
Login.gov IAL2 / senior age verification
Development

Successfully merging this pull request may close these issues.

Engineering: Front-end - Redesign the Get started with Login.gov button
2 participants
@machikoyasuda @thekaveman