Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile/Tablet - Eligibility:Start - Link style, spacing #578

Merged
merged 1 commit into from
May 18, 2022

Conversation

machikoyasuda
Copy link
Member

fixes #538

1. Steps

  • remove ordered list number
  • make icon smaller
  • make links into button with styles

2. Create an account with button

  • Center the whole thing
  • Left-align text

Design consideration questions:

  • What about two-line buttons

image

Screenshots

image

…t number, make icon smaller, make links into button with styles
@machikoyasuda machikoyasuda self-assigned this May 11, 2022
@machikoyasuda machikoyasuda added the front-end HTML/CSS/JavaScript and Django templates label May 11, 2022
@github-actions github-actions bot added the deployment-dev [auto] Changes that will trigger a deploy if merged to dev label May 11, 2022
@machikoyasuda machikoyasuda changed the title Mobile/Tablet - Eligibility:Start page - Link style, spacing Mobile/Tablet - Eligibility:Start - Link style, spacing May 12, 2022
@machikoyasuda machikoyasuda added this to the Login.gov SSO milestone May 12, 2022
@machikoyasuda
Copy link
Member Author

@srhhnry @Indiajar How do the screenshots of the new buttons on mobile look?

@srhhnry
Copy link

srhhnry commented May 17, 2022

Hmmmm. I don't love it, but it's definitely the most logical response (e.g. shrinking the text or changing the button width both don't make much sense). So I'm good with these buttons.

To that point--this looks to be a screen smaller than 576px, or our smallest container, and around the size of an iphone 7 or SE. Should we include a smaller set of screens in the designs moving forward? Here's how I'm reorganizing the Figma screens:

Screen Shot 2022-05-17 at 1 24 53 PM

@machikoyasuda
Copy link
Member Author

@srhhnry The width of the iPhone 7 and iPhone SE (2nd Generation) is much smaller than 576px. According to both Google Chrome and Mozilla Firefox, here are the widths for the major phone sizes:

  • iPhone 6/7/8/SE (2nd Generation)/X/XS/11 Pro/12/13 mini is 375 x 667
  • iPhone 12+ Pro/13+ Pro is 390 x 844
  • iPhone 6/7/8 Plus/XS Max/11 Pro Max is 414 x 738.
  • iPhone 12 Max is 428 x 926

So even though the code can be written so that when a container gets to 576px width or narrower, it shows the design for that Small Container size, it might make sense to include screens at 414px and/or 375px, depending on the page's content/design needs.

Even on the iPhone 12 Max at 428 width, one of the buttons breaks into 2 lines:

image

image

Overall, even though the buttons break into 2 lines, I also find that putting the border around the links makes distinguishes the clickable area much more and looks much cleaner than without the border.

@machikoyasuda machikoyasuda marked this pull request as ready for review May 17, 2022 19:35
@machikoyasuda machikoyasuda requested a review from a team as a code owner May 17, 2022 19:35
@machikoyasuda
Copy link
Member Author

@thekaveman @angela-tran this is ready for review

@machikoyasuda machikoyasuda merged commit 79b1361 into dev May 18, 2022
@machikoyasuda machikoyasuda deleted the fix/538-mobile-eligibility-start-buttons branch May 18, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: Eligibility Start - Button change/Font size changes
3 participants