-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: agency index #430
Conversation
New PO file entries were used for the agency_index content title, paragraphs, and button label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! After merging this PR, need to make a ticket to:
- Get all new Spanish translations and add them
- Finalize CSS for all pages once all the copy and new pages/elements are in.
I'll wait until tomorrow to merge this, in case anyone else wants to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Thanks for this list @machikoyasuda ! I think #359 captures that we're waiting to get finalized Spanish translations. I wouldn't be opposed to also having our own dev-centric ticket for actually adding those Spanish translations in if you think that would be good to have. Do you want to create the GitHub issue for finalizing the CSS once all the pages/elements are in? |
@angela-tran Sounds good! Could you create that CSS ticket after you merge this PR?? Thank you 🙏 |
@angela-tran when you create that new ticket, can you please add it to the list on #363 too? |
Yep, will do 👍 |
Closes #367
Follows approach outlined in the ticket. Using a new template specific to
agency_index
gave us the flexibility to useblocktranslate
for embedding the link to "Learn more about Cal-ITP Benefits."Note that I didn't attempt to style the page. I think @machikoyasuda has an idea for doing a focused cleanup of styles in a separate ticket. Let me know though if that's not correct! 🙏
Latest screen from Figma mockup:
Current view on this branch:
Here's the Before (from dev branch):
UI tests pass