Refactor: rename the finished card tokenization event #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aligns with other start/finish events like for sign in
aligns with other start/finish events like for sign in
github-actions
bot
added
deployment-dev
|
Preview url: https://benefits-2450--cal-itp-previews.netlify.app |
Coverage report
This PR does not seem to contain any modification to coverable code. |
thekaveman
added
the
analytics
angela-tran
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking through the analytics/warehouse as part of cal-itp/data-infra#3468 and I noticed this slight inconsistency.
E.g. our OAuth events use
started sign infinished sign inSo this small fix aligns the card tokenization event.
this was my bad, I wrote the initial spec in #2249