Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eligibility: Filter enrollment flows by supported method #2420

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Eligibility: Filter enrollment flows by supported method #2420

merged 5 commits into from
Oct 2, 2024

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Oct 1, 2024 •
edited
Loading

closes #2396

What this PR does

  • Only display supported enrollment flows (in-person, digital or both) on Eligibility forms for Digital flow and In-Person flow.
  • Update tests: Adds a spec case to both in-person and digital specs, where a form must filter out the 2 supported flows out of 3 total flows.

How to test

  • Set some enrollment flows to be In-Person only or Digital only via the Admin tool
  • Check the digital flow's eligibility page
  • Log in as a CST staff user on Admin and check the in-person flow page

@machikoyasuda machikoyasuda self-assigned this Oct 1, 2024
@machikoyasuda machikoyasuda requested a review from a team as a code owner October 1, 2024 07:03
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. tests Related to automated testing (unit, UI, integration, etc.) labels Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/eligibility
  forms.py
  benefits/in_person
  forms.py
Project Total  

This report was generated by python-coverage-comment-action

angela-tran
angela-tran requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes to application code look great! Noticed some code clean-ups for the test code, but otherwise, what they cover looks great.

tests/pytest/eligibility/test_views.py Outdated Show resolved Hide resolved
tests/pytest/eligibility/test_views.py Outdated Show resolved Hide resolved
tests/pytest/eligibility/test_views.py Outdated Show resolved Hide resolved
tests/pytest/eligibility/test_views.py Outdated Show resolved Hide resolved
tests/pytest/eligibility/test_views.py Outdated Show resolved Hide resolved
tests/pytest/in_person/test_views.py Outdated Show resolved Hide resolved
tests/pytest/in_person/test_views.py Outdated Show resolved Hide resolved
tests/pytest/in_person/test_views.py Outdated Show resolved Hide resolved
@machikoyasuda machikoyasuda force-pushed the refactor/transit-agency-enrollment-flow branch 2 times, most recently from ee92b87 to 2ffa3d1 Compare October 2, 2024 03:37
@machikoyasuda machikoyasuda force-pushed the feat/2396-filter-supported-enrollment-flows branch from b94fe1a to 230ef30 Compare October 2, 2024 04:18
angela-tran
angela-tran reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about ready to merge! The tests look so good - just some typos

tests/pytest/eligibility/test_views.py Outdated Show resolved Hide resolved
tests/pytest/in_person/test_views.py Outdated Show resolved Hide resolved
@machikoyasuda
Copy link
Member Author

@angela-tran fows 😆

@angela-tran
Copy link
Member

angela-tran commented Oct 2, 2024 •
edited
Loading

@machikoyasuda Should we try to get #2403 done and approved / merged before merging this one in?

Base automatically changed from refactor/transit-agency-enrollment-flow to main October 2, 2024 20:27
@machikoyasuda machikoyasuda force-pushed the feat/2396-filter-supported-enrollment-flows branch from d8f5c9a to 673c989 Compare October 2, 2024 20:28
@machikoyasuda
Copy link
Member Author

machikoyasuda commented Oct 2, 2024 •
edited
Loading

image

The big enrollmentflow/agency refactor is now merged to main and deployed to dev, so this PR is now unblocked and ready to be reviewed + merged.

angela-tran
angela-tran approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@machikoyasuda machikoyasuda merged commit 3c39dc3 into main Oct 2, 2024
15 checks passed
@machikoyasuda machikoyasuda deleted the feat/2396-filter-supported-enrollment-flows branch October 2, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
back-end Django views, sessions, middleware, models, migrations etc. tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Milestone
Admin tool: in-person eligibility ver...
Development

Successfully merging this pull request may close these issues.

Use supported_enrollment_methods field to filter flows in digital/in-person views
2 participants
@machikoyasuda @angela-tran