Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enrollment success: All flows now have same success headline copy #2360

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Enrollment success: All flows now have same success headline copy #2360

merged 1 commit into from
Sep 11, 2024

Conversation

machikoyasuda
Copy link
Member

close #2353

@machikoyasuda machikoyasuda requested a review from a team as a code owner September 11, 2024 19:42
@machikoyasuda machikoyasuda self-assigned this Sep 11, 2024
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework labels Sep 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@machikoyasuda machikoyasuda force-pushed the feat/2353-enrollment-success-copy-alignment branch from 64c8def to 8e9f35d Compare September 11, 2024 20:52
lalver1
lalver1 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! At first I was wondering about the use of blocktranslate trimmed in success.html but I see that it makes for a clean .po file because of the indentation 👍

angela-tran
angela-tran approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

@machikoyasuda machikoyasuda merged commit 72349c3 into main Sep 11, 2024
12 checks passed
@machikoyasuda machikoyasuda deleted the feat/2353-enrollment-success-copy-alignment branch September 11, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

@lalver1 lalver1 lalver1 approved these changes

Assignees

@machikoyasuda machikoyasuda

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enrollment:success - update headline for all success templates
3 participants
@machikoyasuda @lalver1 @angela-tran