Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin test: Use settings instead of mocker #2347

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Admin test: Use settings instead of mocker #2347

merged 2 commits into from
Sep 11, 2024

Conversation

machikoyasuda
Copy link
Member

fixes #2316

@machikoyasuda machikoyasuda requested a review from a team as a code owner September 10, 2024 20:40
@github-actions github-actions bot added the tests Related to automated testing (unit, UI, integration, etc.) label Sep 10, 2024
@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@machikoyasuda machikoyasuda self-assigned this Sep 10, 2024
angela-tran
angela-tran previously approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@angela-tran angela-tran dismissed their stale review September 10, 2024 23:57

Missed that settings fixture is not being used

thekaveman
thekaveman approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@machikoyasuda machikoyasuda merged commit d278f34 into main Sep 11, 2024
15 checks passed
@machikoyasuda machikoyasuda deleted the refactor/2316-tests-refactor-settings branch September 11, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

@angela-tran angela-tran Awaiting requested review from angela-tran

Assignees

@machikoyasuda machikoyasuda

Labels
tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Milestone
Benefits admin tool (agency users)
Development

Successfully merging this pull request may close these issues.

Chore: use settings fixture in unit test test_pre_login_user_add_staff_to_group
3 participants
@machikoyasuda @thekaveman @angela-tran