Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Disable Pyright type-checking rules #2346

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

lalver1
Copy link
Member

@lalver1 lalver1 commented Sep 10, 2024

It seems like the August 2024 (version 1.93) release of VS Code enabled type-checking rules in Pyright, resulting in several warnings being generated in the VS Code dev container. This PR disables the type-checking rules to suppress these warnings.

@lalver1 lalver1 self-assigned this Sep 10, 2024
@github-actions github-actions bot added the deployment-dev [auto] Changes that will trigger a deploy if merged to dev label Sep 10, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@lalver1 lalver1 marked this pull request as ready for review September 10, 2024 15:44
@lalver1 lalver1 requested a review from a team as a code owner September 10, 2024 15:44
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lalver1 lalver1 merged commit 79aea2f into main Sep 10, 2024
12 checks passed
@lalver1 lalver1 deleted the chore/pyright-type-checking branch September 10, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants