Feat: in-person enrollment view #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
angela-tran
force-pushed
the
feat/in-person-enrollment-view
branch
2 times, most recently
from
52c6ef4 to
8294377
Compare
angela-tran
force-pushed
the
feat/in-person-enrollment-view
branch
5 times, most recently
from
c55d54b to
b06ea93
Compare
rather than ones from the enrollment app
this is needed so in_person can show its own error templates and because in_person shouldn't necessarily be bound by the same middleware that the eligibility app's /token endpoint is bound by.
the card tokenization flow listens for the `element`'s click event before it will set the iframe `src`. use a Promise to wait for the card tokenization function to finish and then programmatically click the button which is not displayed to the user.
angela-tran
force-pushed
the
feat/in-person-enrollment-view
branch
from
b06ea93 to
a1929af
Compare
|
Getting a front-end error in Firefox: I was able to load the eligibility form, and then I clicked continue to 
|
|
@machikoyasuda It looks like your transit processor is configured with sample values ( |
lalver1
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Nice work @angela-tran! I tested locally and everything worked as expected up until the Littlepay issue.
|
@angela-tran oooh, of course, thank you! will review again. |
machikoyasuda
approved these changes
Sep 16, 2024
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2244
This PR implements the
enrollmentview:GETandPOSTrequests to/in_person/enrollmentThe templates which this view redirects to are all blank. A separate PR will implement
in_person/enrollment/success.html, and #2345 will implement the error templates.This PR also does not include sending analytic events since #2245 will do that.
Testing locally
is_staff:GOOGLE_SSO_STAFF_LISTenvironment variable to*GOOGLE_SSO_ALLOWABLE_DOMAINSenvironment variable iscompiler.la/adminNote: there is currently an issue in the Littlepay QA environment preventing us from finishing enrollment - see #2365. But if it were working, you would successfully enroll and be redirected to a blank success template.
Screenshots
Expand