Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: allow different action URLs on card-tokenize success form #2339

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

angela-tran
Copy link
Member

Part of #2327

This PR makes a small refactor so that CardTokenizeSuccessForm allows for different action_urls. This is needed for the in-person enrollment view.

it was hard-coded to POST to the enrollment index, but we will need it
to POST to the in-person enrollment page.
@angela-tran angela-tran self-assigned this Sep 6, 2024
@angela-tran angela-tran requested a review from a team as a code owner September 6, 2024 18:10
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev back-end Django views, sessions, middleware, models, migrations etc. labels Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/enrollment
  forms.py
  views.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Simple

@angela-tran angela-tran merged commit c5fc5d7 into main Sep 10, 2024
18 checks passed
@angela-tran angela-tran deleted the refactor/CardTokenizeSuccessForm-action_url branch September 10, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants