Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: normalize lines for tag_type #2254

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Chore: normalize lines for tag_type #2254

merged 1 commit into from
Jul 30, 2024

Conversation

lalver1
Copy link
Member

@lalver1 lalver1 commented Jul 30, 2024

Closes #2240

This PR normalizes setting tag_type. It moves the setting of tag_type from the shell into tag.py, consistent with how setting the environment-related variables is done in workspace.py.

@lalver1 lalver1 self-assigned this Jul 30, 2024
@github-actions github-actions bot added the infrastructure Terraform, Azure, etc. label Jul 30, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@lalver1 lalver1 marked this pull request as ready for review July 30, 2024 15:03
@lalver1 lalver1 requested a review from a team as a code owner July 30, 2024 15:03
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I see you pushed an RC tag @lalver1; pipeline ran and the tag_type was set correctly:

image

@lalver1 lalver1 merged commit 146ef17 into main Jul 30, 2024
29 checks passed
@lalver1 lalver1 deleted the chore/normalize-tag branch July 30, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Terraform, Azure, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize lines in tag.py
2 participants