Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Optimize CodeQL analysis #1993

Merged
merged 2 commits into from
Apr 3, 2024
Merged

CI: Optimize CodeQL analysis #1993

merged 2 commits into from
Apr 3, 2024

Conversation

thekaveman
Copy link
Member

Closes #1740

  • Skips analysis for the tests/ directory
  • Conditionally analyzes languages (javascript, python) based on if corresponding files were changed

@github-actions github-actions bot added the actions Related to GitHub Actions workflows label Mar 29, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@thekaveman thekaveman marked this pull request as ready for review March 29, 2024 21:56
@thekaveman thekaveman requested a review from a team as a code owner March 29, 2024 21:56
a new job 'setup' runs first, using the step dorny/paths-filter to see
what file types were changed

then the 'languages' matrix is populated based on that result

this means CodeQL analysis will only run for the language when corresponding
files were changed

see more: https://github.com/dorny/paths-filter?tab=readme-ov-file#conditional-execution
@thekaveman thekaveman force-pushed the ci/codeql-optimization branch from d97441d to 15fc2c7 Compare March 29, 2024 21:58
@thekaveman thekaveman self-assigned this Mar 29, 2024
@thekaveman thekaveman added the chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc. label Mar 29, 2024
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

@thekaveman
Copy link
Member Author

Eh let's merge for now and see what happens / if we need to make adjustments, especially for the scheduled run (I'm thinking that it won't run for any languages since nothing will have changed, but we can figure that out later).

@thekaveman thekaveman merged commit 25e8c0e into dev Apr 3, 2024
8 checks passed
@thekaveman thekaveman deleted the ci/codeql-optimization branch April 3, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions Related to GitHub Actions workflows chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look into speeding up CodeQL checks
2 participants