-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show retry button on enrollment/retry page #1787
Conversation
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely works, but I'm curious why we even have this retry_button
context and the {% if ... %}
check in our template.
Don't we always want to show a retry button on the retry page? Could we just remove this context variable and the template check?
@thekaveman Yeah I wondered the same thing. As long as this Retry page/template is not called from other methods, I don't think we would need the check. Should I just remove? |
I looked through the Git history a little, and it seems like in 4c49895 we just forgot to remove |
Thanks for the find @angela-tran. Yep @machikoyasuda I think we are good to remove this. |
fix #1755
What this PR does
retry_button
asTrue
to theenrollment/retry
page, so that the button appears