Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: sign out button #1534

Merged
merged 11 commits into from
Jul 14, 2023
Merged

Refactor: sign out button #1534

merged 11 commits into from
Jul 14, 2023

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Jul 14, 2023 •
edited
Loading

Closes #1519

Needed for #1520 / #1531

Part of #1442

Sign out link

image

Sign out button

image

@github-actions github-actions bot added the i18n Copy: Language files or Django i18n framework label Jul 14, 2023
@thekaveman thekaveman added this to the Veterans milestone Jul 14, 2023
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev migrations [auto] Review for potential model changes/needed data migrations updates tests Related to automated testing (unit, UI, integration, etc.) back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates and removed migrations [auto] Review for potential model changes/needed data migrations updates tests Related to automated testing (unit, UI, integration, etc.) labels Jul 14, 2023
@thekaveman thekaveman self-assigned this Jul 14, 2023
@thekaveman thekaveman mentioned this pull request Jul 12, 2023
Closed
20 tasks
@thekaveman thekaveman marked this pull request as ready for review July 14, 2023 20:01
@thekaveman thekaveman requested a review from a team as a code owner July 14, 2023 20:01
@thekaveman thekaveman marked this pull request as draft July 14, 2023 20:04
@thekaveman thekaveman marked this pull request as ready for review July 14, 2023 20:20
angela-tran
angela-tran reviewed Jul 14, 2023
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor looks great! Just a minor question about test assertions

tests/pytest/conftest.py Outdated Show resolved Hide resolved
angela-tran
angela-tran reviewed Jul 14, 2023
View reviewed changes
tests/pytest/conftest.py Outdated Show resolved Hide resolved
tests/pytest/conftest.py Outdated Show resolved Hide resolved
tests/pytest/conftest.py Outdated Show resolved Hide resolved
tests/pytest/conftest.py Outdated Show resolved Hide resolved
angela-tran
angela-tran previously approved these changes Jul 14, 2023
View reviewed changes
@thekaveman thekaveman requested a review from angela-tran July 14, 2023 20:59
angela-tran
angela-tran approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thekaveman thekaveman merged commit 6d24a70 into dev Jul 14, 2023
@thekaveman thekaveman deleted the refactor/sign-out branch July 14, 2023 21:01
@thekaveman thekaveman mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework migrations [auto] Review for potential model changes/needed data migrations updates
Projects
None yet
Milestone
Veteran rider enrollment pathway
Development

Successfully merging this pull request may close these issues.

Refactor sign out (Login.gov) copy/button in Enrollment Success
2 participants
@thekaveman @angela-tran